VMM: AVIC work-in-progress - #811
Closed
Teknomancer wants to merge 12 commits into
Closed
Teknomancer wants to merge 12 commits into
Teknomancer wants to merge 12 commits into
Conversation
…hner on the SVM AVIC implementation.
…le VCPU using the AVIC.
Fixed a typo (% vs &) in hmR0SvmExitAvicNoAccel. Ubuntu 26 VM single-VCPU now boots fully without manually triggering an interrupt, like for example pressing a key.
… interrupt from the APIC when AMD AVIC is enabled. This fixes the SMP issue while booting Ubuntu 26 VMs with AVIC.
This is for the upcoming fix in the SVM AVIC incomplete IPI #VMEXIT handler. Tested this change booting Ubuntu 10.04-3 amd64 live CD to ensure it doesn't cause a regression there.
…similar to invalid interrupt type and only kick VCPUs if the failure reason is 'target not running', fail other cases.
…ite and pfnSetEoiFast for the NEM Windows and Linux x86 backends.
… wasn't meant to be committed.
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
…h-808 Includes commits: * VMM: SVM AVIC work-in-progress, continuing work done by Alexander Eichner on the SVM AVIC implementation. * VMM/target-x86: SVM AVIC, include the PDMHasApic check in fUseAvic. Logging nits. * VMM: SVM AVIC work-in-progress. Ubuntu 26 live-CD now boots with single VCPU using the AVIC. * VMM/target-x86: Fix APIC interrupt delivery when SVM AVIC is used. Fixed a typo (% vs &) in hmR0SvmExitAvicNoAccel. Ubuntu 26 VM single-VCPU now boots fully without manually triggering an interrupt, like for example pressing a key. * VMM/target-x86: Fix incorrect force-flag clearing when retreiving the interrupt from the APIC when AMD AVIC is enabled. This fixes the SMP issue while booting Ubuntu 26 VMs with AVIC. * VMM/HM: Don't yet enable AVIC by default, needs more testing. * VMM/APIC: Fix error handling when an illegal vector is sent via an IPI. This is for the upcoming fix in the SVM AVIC incomplete IPI #VMEXIT handler. Tested this change booting Ubuntu 10.04-3 amd64 live CD to ensure it doesn't cause a regression there * VMM/APIC: Comment typo. * VMM/HM: SVM AVIC: Incomplete IPI #VMEXIT nits. Handle invalid target similar to invalid interrupt type and only kick VCPUs if the failure reason is 'target not running', fail other cases. * VMM/target-x86: Added missing stub functions for pfnUpdateApicAfterWrite and pfnSetEoiFast for the NEM Windows and Linux x86 backends. * VMM/target-x86: APIC: Removed temporary additional debug logging that wasn't meant to be committed. github-merge-author: Teknomancer <v.ramshankar@gmail.com> svn:sync-xref-src-repo-rev: r174915
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
Contributor
|
Merged the pull request, thanks! |
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
klaus-vb
pushed a commit
that referenced
this pull request
Aug 19, 2026
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 Includes commits: * VMM: SVM AVIC work-in-progress, continuing work done by Alexander Eichner on the SVM AVIC implementation. * VMM/target-x86: SVM AVIC, include the PDMHasApic check in fUseAvic. Logging nits. * VMM: SVM AVIC work-in-progress. Ubuntu 26 live-CD now boots with single VCPU using the AVIC. * VMM/target-x86: Fix APIC interrupt delivery when SVM AVIC is used. Fixed a typo (% vs &) in hmR0SvmExitAvicNoAccel. Ubuntu 26 VM single-VCPU now boots fully without manually triggering an interrupt, like for example pressing a key. * VMM/target-x86: Fix incorrect force-flag clearing when retreiving the interrupt from the APIC when AMD AVIC is enabled. This fixes the SMP issue while booting Ubuntu 26 VMs with AVIC. * VMM/HM: Don't yet enable AVIC by default, needs more testing. * VMM/APIC: Fix error handling when an illegal vector is sent via an IPI. This is for the upcoming fix in the SVM AVIC incomplete IPI #VMEXIT handler. Tested this change booting Ubuntu 10.04-3 amd64 live CD to ensure it doesn't cause a regression there * VMM/APIC: Comment typo. * VMM/HM: SVM AVIC: Incomplete IPI #VMEXIT nits. Handle invalid target similar to invalid interrupt type and only kick VCPUs if the failure reason is 'target not running', fail other cases. * VMM/target-x86: Added missing stub functions for pfnUpdateApicAfterWrite and pfnSetEoiFast for the NEM Windows and Linux x86 backends. * VMM/target-x86: APIC: Removed temporary additional debug logging that wasn't meant to be committed. github-merge-author: Teknomancer <v.ramshankar@gmail.com> svn:sync-xref-src-repo-rev: r174915
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 [build fix] svn:sync-xref-src-repo-rev: r174916
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 [build fix] svn:sync-xref-src-repo-rev: r174917
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 [build fix] svn:sync-xref-src-repo-rev: r174918
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 [build fix] svn:sync-xref-src-repo-rev: r174920
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 [build fix] svn:sync-xref-src-repo-rev: r174923
tvataire
pushed a commit
to tvataire/virtualbox
that referenced
this pull request
Aug 20, 2026
github:VirtualBoxgh-808 [build fix] svn:sync-xref-src-repo-rev: r174924
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VMM AMD AVIC work. Currently SMP Ubuntu 26.04 boots fine with up to 4 VCPUs. There's still work to be done but this is a good point to commit upstream.